rust: simplify bech32 hrp check #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thompson1985
approved these changes
Oct 3, 2024
Beerosagos
approved these changes
Oct 4, 2024
Comment on lines
+46
to
+47
| let hrp = result.hrp(); | ||
| if hrp.as_str() != params.bech32_hrp_payment { |
There was a problem hiding this comment.
Suggested change
| let hrp = result.hrp(); | |
| if hrp.as_str() != params.bech32_hrp_payment { | |
| if result.hrp().as_str() != params.bech32_hrp_payment { |
There was a problem hiding this comment.
Can't do this as as_str() returns a reference to something inside the hrp instance, so the hrp() value needs to stay alive :(.
Comment on lines
79
to
+80
| let hrp = decoded_addr.hrp(); | ||
| let hrp: &str = hrp.as_str(); | ||
| if hrp != expected_hrp { | ||
| if hrp.as_str() != expected_hrp { |
There was a problem hiding this comment.
Same here, I think you could get rid of the hrp variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.