WIP: cmake cleanup #241
Open
WIP: cmake cleanup #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conte91
force-pushed
the
hsm_cmake_cleanup
branch
3 times, most recently
from
58fe31e
to
85e65cf
Compare
conte91
force-pushed
the
hsm_cmake_cleanup
branch
from
85e65cf
to
436611b
Compare
conte91
force-pushed
the
hsm_cmake_cleanup
branch
from
436611b
to
77df799
Compare
As the files related to APP_BTC don't depend on any PRODUCT* macro, but only on the APP_* macros, move those to a separate CMake unit (app_btc-multi, app_btc-btc), to avoid multiple unnecessary compilations.
Most of the workflow, components, and UI code doesn't depend on the platform it will be run on. Compile it only once to save many CMake build entries. The gestures code is a dependency of most components, but it has a slight dependency on the hardware platform. Split it into an API and an implementation file to let including the header possible without having to define the platform the code will run on.
conte91
force-pushed
the
hsm_cmake_cleanup
branch
from
77df799
to
e65d808
Compare
Instead of #defininig all the possible PRODUCT_ macros, it makes more sense to enforce the definition of the (limited) PLATFORM_ and EDITION_ macros, and extract the relevant definitions of PRODUCT_* from there. This makes it easier to enforce that the macros are defined consistently, and allows further separation of code that is dependent on the platform it will run on, but not on the edition (e.g. the touch code depends on the PLATFORM_*, but it doesn't matter whether it will run on a -multi or on a -btconly device).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract common files in the CMakeLists.txt when possible, to avoid recompiling the same source file over and over with different flags.