BTC-1553: fix isValidAddress by returning false for valid cashaddr bch addresses #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkaplanbitgo
previously approved these changes
Oct 11, 2024
kcheng-bitgo
changed the title
kcheng-bitgo
force-pushed
the
BTC-1553-false-invalid-bch-cashaddr
branch
from
6ffc0e7
to
d64b6cd
Compare
davidkaplanbitgo
approved these changes
Oct 11, 2024
OttoAllmendinger
requested changes
Oct 12, 2024
| @@ -415,10 +415,15 @@ export abstract class AbstractUtxoCoin extends BaseCoin { | |||
| throw new Error('deprecated'); | |||
| } | |||
|
|
|||
| const formats = param && param.anyFormat ? undefined : ['default' as const]; | |||
There was a problem hiding this comment.
So previously the anyFormat flag controlled this behavior. What you want to do here is make anyFormat = true the default.
| try { | ||
| const script = utxolib.addressFormat.toOutputScriptTryFormats(address, this.network, formats); | ||
| return address === utxolib.address.fromOutputScript(script, this.network); |
There was a problem hiding this comment.
you can just remove this line - toOutputScriptsTryFormats will fail if it cannot parse the address with any of the formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: BTC-1553
Previously,
isValidAddressverified the address by converting it to script and back. However, the previous implementation converts the script back to the legacy address and compares it against the original address. Thus, if the original was cashaddr format, it would fail. Fix this by generating addresses in all formats from the script and check if the original address is included.