Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnreachableWhiteCellContradictionRule Pathfinding #321

Merged
merged 12 commits into from
Oct 21, 2022

Conversation

19690ao
Copy link
Collaborator

@19690ao 19690ao commented Oct 7, 2022

Description

Closes #300

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Both the UnreachableWhiteCellContradictionRule and its corresponding CannotReachCell basic rule will now be able to use any black and/or numbered cells to determine that a cell isn't reachable from any region.
image
This is a screenshot of this proof file:
prtestproof.zip

If I instead try to choose every square for the rule, I'm shown exactly which ones can and can't be reached.
image

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, passes tests and corner cases I derived

@Chase-Grajeda Chase-Grajeda merged commit 3df368c into Bram-Hub:dev Oct 21, 2022
@19690ao 19690ao deleted the cannotreachpathing branch October 25, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants