Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to Version 7.5.1 #456

Merged
merged 8 commits into from
Feb 17, 2023

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Feb 16, 2023

Description

Re-attempting certain changes made in #401.

  • Upgraded Gradle to 7.5.1
  • Added gradle.properties to show Gradle deprecation warnings when compiling
  • Updated code to no longer use deprecated Gradle features
  • Added a GitHub action to deploy javadocs to GitHub Pages, hosted off the javadoc branch

Note: I did not attempt to update or remove some dependencies in this pull request. I will do that in a separate pull request in the future; however, I am not prioritizing that right now.

Closes #289

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

The jar file seems to compile. Since I did not change any of the source code, this should be sufficient.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 marked this pull request as ready for review February 16, 2023 14:46
@charlestian23 charlestian23 changed the title Re-attempting Select Gradle Changes Upgrade Gradle to Version 7.5.1 Feb 17, 2023
@Corppet Corppet merged commit 7f28566 into Bram-Hub:dev Feb 17, 2023
@charlestian23 charlestian23 deleted the select_gradle_changes branch February 28, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants