Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treetent puzzle editor #692

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

jac-oblong
Copy link
Collaborator

Description

Uses the code from #530 to fix the treetent puzzle editor.

Where very simple fixes. There was a switch statement missing "break"s. And the TreeTent puzzle exporter was exporting string values, while the importer expected integers.

Closes #503, #530

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Created a puzzle using the editor and successfully opened it back up.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jac-oblong
Copy link
Collaborator Author

Once this is merged, #530 should be closed.

charlestian23

This comment was marked as outdated.

@charlestian23

This comment was marked as outdated.

Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made are fine. I'd prefer if right clicking the numbers in the Tree Tent puzzle editor would decrease the numbers, since right now, right clicking and left clicking both increases them.

@jac-oblong
Copy link
Collaborator Author

Differing between right/left click should work now

@charlestian23 charlestian23 self-requested a review December 1, 2023 19:58
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good, merging.

@charlestian23 charlestian23 merged commit ca9fef9 into dev Dec 1, 2023
7 checks passed
@charlestian23 charlestian23 deleted the new-fix-treetent-puzzle-editor branch January 30, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants