Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Remove deprecated indices function #294

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

halungge
Copy link
Contributor

remove deprecated 'get_indices_from_tofunction fromIconGrid`.

  • replace by separate get_start_index, get_end_index
  • rename the returned indices variables
  • delete deprecated function and corresponding tests.

@halungge
Copy link
Contributor Author

cscs-ci run

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge halungge merged commit e35b853 into main Oct 19, 2023
5 checks passed
@halungge halungge deleted the remove_deprecated_indices_function branch October 19, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants