Fix cleanup velocity advection fields

[halungge]

Simplify interfaces to solve_nonhydro.time_step

• use static edge fields from initialization
• use internally calculated scaling factors in velocity_advection

[github-actions]

Mandatory Tests

Please make sure you run these tests via comment before you merge!

• cscs-ci run
• launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

• launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

[halungge]

cscs-ci run

[halungge]

launch jenkins spack

[OngChia]

Looks good.
I am wondering why the cell_areas, nh_constants, and bdy_divdamp cannot be also removed as input arguments? It is because scal_divdamp cannot be computed properly?

[halungge]

Looks good. I am wondering why the cell_areas, nh_constants, and bdy_divdamp cannot be also removed as input arguments? It is because scal_divdamp cannot be computed properly?

They can, I believe. The cell_areas is easy the others need a closer look. The ZFields are the ones that need to be reset per timestep, so cannot be treated as constants inside SolveNonhydro.