Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using custom workspaces in jenkins #325

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Using custom workspaces in jenkins #325

merged 8 commits into from
Dec 1, 2023

Conversation

abishekg7
Copy link
Contributor

No description provided.

@abishekg7
Copy link
Contributor Author

launch jenkins spack

@abishekg7
Copy link
Contributor Author

launch jenkins icon

@abishekg7
Copy link
Contributor Author

cscs-ci run

@abishekg7
Copy link
Contributor Author

launch jenkins icon

@samkellerhals samkellerhals self-requested a review December 1, 2023 11:05
Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. So basically before we did not have concurrent builds and now we do as each one happens in a per build workspace? Only question I have is are the build numbers always unique, and will jenkins create these new custom workspace folders if they do not exist? Also will these folders be deleted over time, or do we need to do some sort of cleanup afterwards?

Copy link

github-actions bot commented Dec 1, 2023

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@abishekg7
Copy link
Contributor Author

Looks good to me. So basically before we did not have concurrent builds and now we do as each one happens in a per build workspace? Only question I have is are the build numbers always unique, and will jenkins create these new custom workspace folders if they do not exist? Also will these folders be deleted over time, or do we need to do some sort of cleanup afterwards?

Thanks! So we did have concurrent builds before, but when we introduced spack to the build process, it started interpreting the @ in the concurrent build workspace names as a version specifier and then failed. So then we disabled concurrent builds to avoid this issue, but that slowed down our workflow. Now we are switching to underscore in the build directory, which satisfies spack at least.

And we cleanup the workspace after each build with this

post { always { archiveArtifacts artifacts: 'local_copy/spack*.txt', allowEmptyArchive: true echo 'Cleaning up workspace' deleteDir() } }

@abishekg7
Copy link
Contributor Author

launch jenkins icon

@abishekg7
Copy link
Contributor Author

cscs-ci run

@abishekg7
Copy link
Contributor Author

launch jenkins spack

@abishekg7 abishekg7 merged commit 5ef2b73 into main Dec 1, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants