Corrector stencil 60

[halungge]

(Fix): Add missing call to mo_solve_nonhydro_stencil_60 in corrector step.

Fix control flow related to mo_solve_nonhydro_stencil_59 (predictor) and mo_solve_nonhydro_stencil_60 (corrector): driver code determines whether first or last substep is run, since it controls the entire substep loop.

[halungge]

cscs-ci run default

[halungge]

launch jenkins spack

[OngChia]

I think it is nice to have the at_first_substep and at_last_substep swithces.
Similar to config parameter ndyn_substeps_var in solve_nonhydro, I noticed that there is also a config parameter ndyn_substeps in diffusion. Because the number of substeps may dynamically change during runtime, I wonder that whether those variables in initialization of diffusion that use ndyn_substeps are also affected. If so, perhaps it can also be added as a TODO there in the future.

[halungge]

I think it is nice to have the at_first_substep and at_last_substep swithces. Similar to config parameter ndyn_substeps_var in solve_nonhydro, I noticed that there is also a config parameter ndyn_substeps in diffusion. Because the number of substeps may dynamically change during runtime, I wonder that whether those variables in initialization of diffusion that use ndyn_substeps are also affected. If so, perhaps it can also be added as a TODO there in the future.

I agree. I did not know at the time that it could change dynamically. We should have a do a consolidation "pass through" with just this ndyn_substeps business in mind and fix it consistently everywhere.

[halungge]

launch jenkins spack

[halungge]

cscs-ci run default

[abishekg7]

Looks good!

[abishekg7]

why is this staticmethod and not the other one?

[halungge]

the other accesses the class content, so you need the `self

[halungge]

launch jenkins spack

[github-actions]

Mandatory Tests

Please make sure you run these tests via comment before you merge!

• cscs-ci run default
• launch jenkins spack

Optional Tests

To run benchmarks you can use:

• cscs-ci run benchmark

In case your change might affect downstream icon-exclaim, please consider running

• launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

[halungge]

cscs-ci run default