add C2V connectivity to the IconGrid generated from serialbox data #357
Conversation
|
cscs-ci run default |
|
cscs-ci run benchmark |
|
launch jenkins spack |
There was a problem hiding this comment.
Looks good. I remember encountering an issue related to this Dimension and I ended up removing it from the list of offset providers in the SimpleGrid, but didn't look further into it. So it turns out we do need this connectivity after all. I guess it failed at the time since it was not being read into the grid from the serialbox reader? My question is do we need to readd this connectivity here or not?
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run benchmark |
|
launch jenkins spack |
|
cscs-ci run default |
(FIX) C2V connectivity was not read from the serialized data, even though it is there and is available in the other grid topology sources like the SimpleGrid and ICON grid file