Fix automatic closure domain argument adaption #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run default |
samkellerhals
requested changes
Jan 31, 2024
There was a problem hiding this comment.
In principle it looks good to me however the icon-exclaim PR is failing https://jenkins-mch.cscs.ch/blue/organizations/jenkins/EXCLAIM%2Ficon-gt4py-pr/detail/icon-gt4py-pr/946/pipeline I think you need to pull from main to get the new stencil names. As soon as the cscs ci for this branch and for icon-exclaim are green we can merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the domain of a fencil closure was automatically set to
unstructured_domain(named_range("horizontal", horizontal_start, horizontal_end)), named_range("K", vertical_start, vertical_end))regardless of what the horizontal dimension actually was. This lead to some problems with the temporary pass requires the correct name of the dimension. This PR fixes that by generating something like:
unstructured_domain(named_range("Cell", horizontal_start, horizontal_end)), named_range("K", vertical_start, vertical_end))Additionally I generalized the function to support multiple closures, but kept the error message because I didn't test it.