Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case string cleaning for DSL INSERT #381

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

samkellerhals
Copy link
Contributor

No description provided.

@samkellerhals
Copy link
Contributor Author

samkellerhals commented Feb 7, 2024

cscs-ci run default

@huppd
Copy link
Contributor

huppd commented Feb 7, 2024

cscs-ci run default

@huppd
Copy link
Contributor

huppd commented Feb 7, 2024

launch jenkins spack

Copy link

github-actions bot commented Feb 8, 2024

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@samkellerhals
Copy link
Contributor Author

cscs-ci run default

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

Copy link
Contributor

@huppd huppd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@samkellerhals samkellerhals merged commit 8035531 into main Feb 8, 2024
5 checks passed
@samkellerhals samkellerhals deleted the special-case-dsl-insert-string-cleaning branch February 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants