Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input field slicing in stencil tests #390

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

edopao
Copy link
Collaborator

@edopao edopao commented Feb 21, 2024

Support for array offset will soon be deprecated in DaCe, which means that DaCe backend will not accept slice of ndarrays as input fields. The filed domain should therefore start from 0.
This PR updates some test cases to pass the full filed domain to the stencil. The reference field used for validation checks that the elements outside the closure domain are not modified.

@edopao edopao marked this pull request as ready for review February 21, 2024 09:42
@edopao edopao requested a review from muellch February 21, 2024 09:56
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@edopao
Copy link
Collaborator Author

edopao commented Feb 21, 2024

cscs-ci run default

@samkellerhals
Copy link
Contributor

launch jenkins spack

@edopao edopao merged commit de1c599 into main Feb 22, 2024
5 checks passed
@edopao edopao deleted the remove_input_field_slicing branch February 22, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants