-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow whitespaces in START STENCIL directive for name argument #414
Allow whitespaces in START STENCIL directive for name argument #414
Conversation
cscs-ci run default |
1 similar comment
cscs-ci run default |
…l_name_syntax_validation
cscs-ci run default |
launch jenkins spack |
cscs-ci run default |
launch jenkins spack |
…l_name_syntax_validation
…l_name_syntax_validation
cscs-ci run default |
launch jenkins spack |
1 similar comment
launch jenkins spack |
launch jenkins spack |
launch jenkins spack |
This reverts commit a7dd889.
launch jenkins spack |
cscs-ci run default |
launch jenkins spack |
…l_name_syntax_validation
cscs-ci run default |
launch jenkins spack |
…l_name_syntax_validation
cscs-ci run default |
launch jenkins spack |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
cscs-ci run default |
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adapting the tests.
This PR applies some small changes in the regex matching the
name
argument specified in Liskov'sSTART STENCIL
directives. The new syntax allows having whitespaces on thename
line. E.g.:instead of just