Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove zero stencils from dycore/state_utils/utils.py #425

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Mar 25, 2024

  • remove idiv_method from SolveNonHydroConfig as the namelist option was removed in ICON
  • update serialized data to include fields needed in datatest for interpolation fields:
    - restrict verification of internal fields in predictor step to the domain calculated
  • remove duplicated zero-stencils

remove idiv_method from SolveNonHydroConfig
@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

cscs-ci run default

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge halungge marked this pull request as ready for review March 26, 2024 11:45
Copy link
Contributor

@abishekg7 abishekg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just had one comment

@halungge halungge merged commit e68db25 into main Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants