WIP: Greenline metrics coefficients aj #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halungge
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Most of them are simple stencil calculation that compute regular (not sparse fields) like Field[[CellDim, KDim], wpfloat] or Field[[EdgeDim, KDim], wpfloat] there is no reason to do this in numpy instead of gt4py.
Also, thinks about where you put the functions, either put everything below common/metrics/ or the more general functions like the gradients in common/math
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/tests/interpolation_tests/test_interpolation_fields3.py
Outdated
Show resolved
Hide resolved
…lation_coefficients3_aj
halungge
changed the title
halungge
requested changes
Apr 22, 2024
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/tests/interpolation_tests/test_interpolation_fields3.py
Outdated
Show resolved
Hide resolved
…ion_fields3.py Co-authored-by: Magdalena <luzm@ethz.ch>
…_interpolation_coefficients3_aj
halungge
requested changes
Apr 24, 2024
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/interpolation/interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/tests/interpolation_tests/test_interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/tests/interpolation_tests/test_interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/tests/interpolation_tests/test_interpolation_fields3.py
Outdated
Show resolved
Hide resolved
model/common/tests/interpolation_tests/test_interpolation_fields3.py
Outdated
Show resolved
Hide resolved
nfarabullini
force-pushed
the
greenline_interpolation_coefficients3_aj
branch
from
7928040
to
53c5ac6
Compare
model/common/src/icon4py/model/common/interpolation/interpolation_fields.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run default |
|
launch jenkins spack |
halungge
requested changes
Apr 26, 2024
model/common/src/icon4py/model/common/interpolation/interpolation_fields.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Magdalena <luzm@ethz.ch>
Co-authored-by: Magdalena <luzm@ethz.ch>
|
cscs-ci run default |
|
launch jenkins spack |
halungge
approved these changes
Apr 29, 2024
…_interpolation_coefficients3_aj
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first metric coefficients