Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer advection stencils - Part 1 #93

Merged
merged 13 commits into from
Oct 14, 2022

Conversation

abishekg7
Copy link
Contributor

@abishekg7 abishekg7 commented Sep 20, 2022

hflx_limiter_mo_stencil_01 - Part 1
hor_adv_stencil_01
step_advection_stencil_03
upwind_hflux_miura_stencil_01
vert_adv_stencil_01

@abishekg7 abishekg7 marked this pull request as ready for review September 20, 2022 14:34
rhodz_new = random_field(mesh, CellDim, KDim)
geofac_div = random_field(mesh, CellDim, C2EDim)
geofac_div_new = as_1D_sparse_field(geofac_div, CEDim)
tracer_new = random_field(mesh, CellDim, KDim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you don't need to set this explicitly to np.float64 that won't make a difference to just set p_dtime=5.0 ..

Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The 2nd part of hflx_limiter_mo_stencil_01 is missing.

Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abishekg7 abishekg7 merged commit ef0df62 into tracer_advection_stencils Oct 14, 2022
@samkellerhals samkellerhals deleted the advection_stencils_agopal branch November 16, 2022 09:15
ninaburg pushed a commit that referenced this pull request Nov 29, 2022
Co-authored-by: Magdalena Luz <luzm@ethz.ch>
Co-authored-by: Nicoletta Farabullini <41536517+nfarabullini@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants