Tracer advection stencil porting ml -> tracer advection stencils #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
halungge
commented
Sep 29, 2022
halungge
commented
- hflx_limiter_mo_stencil_02
- hflx_limiter_mo_stencil_03
- hflx_limiter_mo_stencil_04
- step_advection_01
- step_advection_02
- upwind_hflux_miura_stencil_02
- upwind_vflux_ppm_stencil_01
abishekg7
reviewed
Sep 30, 2022
This reverts commit 99638df.
…parate sums instead of using neighbor_sum
halungge
force-pushed
the
tracer_advection_porting_ml
branch
from
769a799
to
9574f77
Compare
halungge
changed the title
halungge
force-pushed
the
tracer_advection_porting_ml
branch
from
9574f77
to
2efb391
Compare
ninaburg
pushed a commit
that referenced
this pull request
Nov 29, 2022
* adding hflx_limiter_mo_stencil_02 * changes order of args and return a tuple * Revert "changes order of args and return a tuple" This reverts commit 99638df. * porting step_advection_stencil_01 * porting step_advection_stencil_02 * porting upwind_hflux_miura_stencil_02 * hflx_limiter_mo_stencil_04 * fix step_advection_stencil_01 * hflx_limiter_mo_stencil_03 * clean up: move upwind_hflux_miura_stencil_02.py * add test for conditional branch in hflx_limiter_mo_stencil_04 * switch to using min_over in hflx_limiter_mo_stencil_03 * refactor hflx_limiter_mo_stencil_04, fix tests for Koffset * add upwind_vflux_ppm_stencil_01 * upwind_hflux_miura_stencil_02 - fix sparse field issue, split into separate sums instead of using neighbor_sum * remove commented out code * fix: upwind_vflux_ppm_stencil_01 * fix: hflx_limiter_mo_stencil_01: return tuple, use int32 * hflx_limiter_pd_stencil_02.py: use int fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.