Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make create_mirror_view_and_copy similar to the other create_mirror* functions #9

Draft
wants to merge 1 commit into
base: refactor/create-mirror/move_intelligence
Choose a base branch
from
Draft

Make create_mirror_view_and_copy similar to the other create_mirror* functions #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions core/src/Kokkos_CopyViews.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3612,13 +3612,11 @@ void check_view_ctor_args_create_mirror_view_and_copy() {
"not explicitly allow padding!");
}

} // namespace Impl

template <class... ViewCtorArgs, class T, class... P,
template <class T, class... P, class... ViewCtorArgs,
class = std::enable_if<std::is_void<typename ViewTraits<T, P...>::specialize>::value>>
auto create_mirror_view_and_copy(
const Impl::ViewCtorProp<ViewCtorArgs...>& arg_prop,
const Kokkos::View<T, P...>& src) {
const Kokkos::View<T, P...>& src,
const Impl::ViewCtorProp<ViewCtorArgs...>& arg_prop) {
using alloc_prop_input = Impl::ViewCtorProp<ViewCtorArgs...>;

Impl::check_view_ctor_args_create_mirror_view_and_copy<ViewCtorArgs...>();
Expand Down Expand Up @@ -3649,20 +3647,25 @@ auto create_mirror_view_and_copy(
}
}

// Previously when using auto here, the intel compiler 19.3 would
// sometimes not create a symbol, guessing that it somehow is a combination
// of auto and just forwarding arguments (see issue #5196)
} // namespace Impl

// space and name
template <class Space, class T, class... P,
typename Enable = std::enable_if_t<Kokkos::is_space<Space>::value>>
typename Impl::MirrorViewType<Space, T, P...>::view_type
create_mirror_view_and_copy(
class = std::enable_if_t<Kokkos::is_space<Space>::value>>
auto create_mirror_view_and_copy(
const Space&, const Kokkos::View<T, P...>& src,
std::string const& name = "",
std::enable_if_t<
std::is_void<typename ViewTraits<T, P...>::specialize>::value>* =
nullptr) {
return create_mirror_view_and_copy(
Kokkos::view_alloc(typename Space::memory_space{}, name), src);
std::string const& name = "") {
return Kokkos::Impl::create_mirror_view_and_copy(
src,
Kokkos::view_alloc(typename Space::memory_space{}, name));
}

// view_constructor_args
template <class T, class... P, class... ViewCtorArgs>
auto create_mirror_view_and_copy(
const Impl::ViewCtorProp<ViewCtorArgs...>& arg_prop,
const Kokkos::View<T, P...>& src) {
return Kokkos::Impl::create_mirror_view_and_copy(src, arg_prop);
}

} /* namespace Kokkos */
Expand Down