Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/init entity def #560

Merged
merged 7 commits into from
Oct 27, 2022
Merged

Feature/init entity def #560

merged 7 commits into from
Oct 27, 2022

Conversation

chahank
Copy link
Member

@chahank chahank commented Oct 26, 2022

Changes proposed in this PR:

  • Update the entity to use typing
  • Update entity init

This PR fixes issue #

PR Author Checklist

PR Reviewer Checklist

@chahank chahank changed the base branch from main to develop October 27, 2022 13:00
@emanuel-schmid emanuel-schmid merged commit 513c1f5 into develop Oct 27, 2022
@emanuel-schmid emanuel-schmid deleted the feature/init-entity-def branch October 27, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanuel-schmid emanuel-schmid emanuel-schmid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chahank @emanuel-schmid