Update ImpactFuncSet.__init__ #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove initialization with set because it does not guarantee insertion order.
# Conflicts: # climada/entity/impact_funcs/impact_func_set.py # climada/entity/impact_funcs/test/test_imp_fun_set.py # doc/tutorial/climada_engine_Forecast.ipynb
|
@peanutfun - what needs yet to be done before this is ready to merge? |
|
Hm, seems like I missed some occurances of the constructor. Thanks for adding them, @emanuel-schmid! I was wondering if we should keep the Otherwise, from what I can see, this is ready to go! |
|
Valid point. Though, the whole |
|
🙌 |
simonameiler
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Add all ImpactFunc attributes to ImpactFunc.__init__ * Add type hints to ImpactFunc.__init__ * Update ImpactFunc classmethods to new init * Update tests to new ImpactFunc.__init__ * Update docs on InputVar regarding ImpactFunc * Update tutorials with new ImpactFunc.__init__ * Update ImpactFunc.__init__ docstring * Update argument order of ImpactFunc.__init__ * Fix linter issue * Update tests to new ImpactFunc.__init__ * Update tutorials with new ImpactFunc.__init__ * Enable passing impact funcs to ImpactFuncSet constructor * Update code base to new ImpactFuncSet constructor * Fix unit test of ImpactFuncSet Remove initialization with set because it does not guarantee insertion order. * undo re-plotting * Incorporate new ImpactFuncSet.__init__ method Co-authored-by: emanuel-schmid <schmide@ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
ImpactFuncs to theImpactFuncSetconstructorNote: This is branched off #550, which should be merged before this branch.
PR Author Checklist
develop)PR Reviewer Checklist