Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/init unsequa #573

Merged
merged 23 commits into from
Nov 1, 2022
Merged

Feature/init unsequa #573

merged 23 commits into from
Nov 1, 2022

Conversation

chahank
Copy link
Member

@chahank chahank commented Oct 27, 2022

Changes proposed in this PR:

  • Update init of unsequa
  • Add typing
  • Set base class init to empty
  • Add constants as class attributes

This PR fixes issue #

PR Author Checklist

PR Reviewer Checklist

Evelyn-M and others added 16 commits October 26, 2022 15:08
@Evelyn-M
abort mission
fc013d1
@Evelyn-M
update calc_base.Calc method
6238863
@Evelyn-M
update calc_impact.Calc method
78eba33
@Evelyn-M
update calc_costbenefit.CalcCostBenefit method
f8d2f91
@Evelyn-M
update init input_var
b2e78fc
Merge branch 'develop' into feature/init_unsequa_calc_impact
2f7ff10
Merge branch 'develop' into feature/init_unsequa_calc_costbenefit
f0f0b5c
Merge branch 'develop' into feature/init_unsequa_calc_base
d9f7843
Merge branch 'develop' into feature/init_unseque_input_var
597c426
Merge branch 'develop' into feature/init_unsequa_unc_output
5af2836
Merge branch 'feature/init_unseque_input_var' into feature/init-unsequa
a2b76f5
Merge branch 'feature/init_unsequa_unc_output' into feature/init-unsequa
a3b2e2a
Merge remote-tracking branch 'origin/feature/init_unsequa_calc_base' …
1a796ac 
…into feature/init-unsequa
Merge branch 'feature/init_unsequa_calc_costbenefit' into feature/ini…
a22b46b 
…t-unsequa
Merge branch 'feature/init_unsequa_calc_impact' into feature/init-uns…
131f0f0 
…equa
Set base class attributes as class attributes
9d51ad4
@tovogt tovogt self-requested a review October 27, 2022 14:19
@tovogt tovogt merged commit 156c6fc into develop Nov 1, 2022
@emanuel-schmid emanuel-schmid deleted the feature/init-unsequa branch November 2, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovogt tovogt Awaiting requested review from tovogt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chahank @tovogt @Evelyn-M