Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readthedocs update #656

Merged
merged 5 commits into from
Feb 17, 2023
Merged

readthedocs update #656

merged 5 commits into from
Feb 17, 2023

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Feb 16, 2023

General improvement of the docs

Changes proposed in this PR:

  • Python modules get their own caption in the upper part of the navigation column
  • README is duplicated, once for the readthedocs and once for github. This is not sustainable in the long run. But for this release it seems convenient.
  • some links from were fixed
  • some pydoc cosmetics

This PR circumvents #658

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid
Copy link
Collaborator Author

#658 has not been addressed yet because, afaik, it's the only place where we tell how we want to be cited.
Which should be part of the documentation - shouldn't it?

@peanutfun
Copy link
Member

We can of course add the information how we wish to be cited to the documentation index. It would also be nice to add a separate documentation page that lists all publications on Climada.

Comment on lines +67 to +71
.. toctree::
:caption: API Reference
:hidden:

Python Modules <climada/climada>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not rename "Python Modules" to "API Reference", and leave it in the original toctree? I would not add this as a separate toctree with caption because I don't see that we add any other entries in the future. And a separate caption for only a single item does not make much sense to me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It definitely deserves its own section. (I agree that a single item is a wee bit awkward. I wanted to make the section title [API Reference] interactive and unfold subsections only when I actually click on it, but I couldn't figure out how to do that.)
  2. For making navigation easier. When I browse through the API reference and its navigation is at the bottom of the page I lose context through re-rendering whenever I click on a module. When it's on top, the unfolded doc-tree is stable.

@emanuel-schmid
Copy link
Collaborator Author

We can of course add the information how we wish to be cited to the documentation index. It would also be nice to add a separate documentation page that lists all publications on Climada.

👍 True. But not yet in 3.3, I'd say. 😁

@emanuel-schmid
Copy link
Collaborator Author

@peanutfun: Do you mind if I merge now?

@emanuel-schmid emanuel-schmid merged commit fa4b129 into develop Feb 17, 2023
@emanuel-schmid emanuel-schmid deleted the feature/toctree_updates branch February 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants