Catch case where new Hazard fraction is unintentionally zero #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chahank
reviewed
Apr 11, 2024
chahank
reviewed
Apr 11, 2024
chahank
reviewed
Apr 11, 2024
|
All good, but weirdly some unit test for plotting are failing ... I have not yet understood were the failure comes from. |
|
There remains an error with the compatibility with Petals, but I think this is unrelated. Good to merge! |
|
Yes, the error is related to the centroids PRs. Will merge. |
|
Very well. Many thanks! 🙌 |
gdeskos
pushed a commit
to gdeskos/climada_python
that referenced
this pull request
Sep 16, 2024
…-project#869) * Catch case where new Hazard fraction is unintentionally zero * Eliminate zeros in fraction matrix before selecting * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #866
PR Author Checklist
develop)PR Reviewer Checklist