Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/blocking #293

Merged
merged 23 commits into from
Oct 2, 2024
Merged

Feature/blocking #293

merged 23 commits into from
Oct 2, 2024

Conversation

thabisomatau
Copy link
Contributor

@thabisomatau thabisomatau commented Oct 2, 2024

Description

blocking functionality

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other: (summarise briefly here)

Changes Made

users can now block other users and stuff

Does this break anything? (Modifying more expected behaviour/layout, etc)

  • Yes
  • No

Screenshots (if applicable)

WhatsApp Image 2024-10-01 at 19 39 59_63e0592b
WhatsApp Image 2024-10-01 at 19 39 19_b9ac75bf
WhatsApp Image 2024-10-01 at 19 40 56_efb78875

Performance Implications

[Discuss any potential performance implications or improvements]

Related Issues

[Link all issues related to this PR, eg. https://github.com/COS301-SE-2024/TuneIn/...]

Dependencies

[List any new dependencies or updates]

Checklist

  • I have tested this code locally
  • I have reviewed the code for readability and maintainability
  • I have added appropriate documentation or updated existing documentation
  • I have ensured that my changes follow the project's coding conventions
  • I have performed additional steps, if required [e.g., database migrations, configuration changes, etc.]

Additional Notes

This PR is just for blocking functionality and all the implications that come with blocking a user. a different profile view should maybe be discussed as being able to see a blocked user's activity kinda doesn't make sense in my opinion

(ignore) A checklist for the reviewer to use

## Reviewer Checklist
- [ ] Code quality and readability
- [ ] Adequate documentation
- [ ] Follows project coding conventions
- [ ] Considered security implications
- [ ] Considered accessibility implications
- [ ] Considered performance implications
- [ ] Tested locally

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 22.95082% with 141 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (0eb636f) to head (b3c324a).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
frontend/app/screens/profile/ProfilePage.tsx 32.72% 37 Missing ⚠️
backend/src/modules/users/users.service.ts 12.19% 36 Missing ⚠️
backend/src/modules/dto-gen/dto-gen.service.ts 3.84% 25 Missing ⚠️
frontend/app/components/FollowBottomSheet.tsx 0.00% 10 Missing ⚠️
backend/src/modules/search/search.controller.ts 0.00% 8 Missing ⚠️
...ntend/app/components/profile/DrawerContextMenu.tsx 11.11% 8 Missing ⚠️
backend/src/modules/db-utils/db-utils.service.ts 50.00% 6 Missing ⚠️
backend/src/modules/rooms/rooms.service.ts 0.00% 6 Missing ⚠️
backend/src/modules/search/search.service.ts 73.33% 4 Missing ⚠️
backend/src/modules/users/users.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #293      +/-   ##
===========================================
- Coverage    34.14%   33.45%   -0.70%     
===========================================
  Files          235      235              
  Lines        12899    13014     +115     
  Branches      2754     2765      +11     
===========================================
- Hits          4405     4354      -51     
- Misses        8462     8629     +167     
+ Partials        32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Linda-Masia Linda-Masia merged commit c2411c3 into develop Oct 2, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants