Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/network requests #294

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Hotfix/network requests #294

merged 7 commits into from
Oct 2, 2024

Conversation

Linda-Masia
Copy link
Contributor

Description

[Describe the purpose of this pull request]

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other: (summarise briefly here)

Changes Made

[List the specific changes made in this pull request]

Does this break anything? (Modifying more expected behaviour/layout, etc)

  • Yes
  • No

Screenshots (if applicable)

[Include any relevant screenshots or images]

Performance Implications

[Discuss any potential performance implications or improvements]

Related Issues

[Link all issues related to this PR, eg. https://github.com/COS301-SE-2024/TuneIn/...]

Dependencies

[List any new dependencies or updates]

Checklist

  • I have tested this code locally
  • I have reviewed the code for readability and maintainability
  • I have added appropriate documentation or updated existing documentation
  • I have ensured that my changes follow the project's coding conventions
  • I have performed additional steps, if required [e.g., database migrations, configuration changes, etc.]

Additional Notes

[Include any additional notes or context relevant to the pull request]

(ignore) A checklist for the reviewer to use

## Reviewer Checklist
- [ ] Code quality and readability
- [ ] Adequate documentation
- [ ] Follows project coding conventions
- [ ] Considered security implications
- [ ] Considered accessibility implications
- [ ] Considered performance implications
- [ ] Tested locally

@Linda-Masia Linda-Masia added frontend Frontend-related work medium priority Important but not urgent Demo 4 labels Oct 2, 2024
@Linda-Masia Linda-Masia self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 34.04%. Comparing base (c2411c3) to head (6983d84).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
frontend/app/screens/followers/Followers.tsx 0.00% 5 Missing ⚠️
frontend/app/screens/followers/Following.tsx 0.00% 1 Missing ⚠️
frontend/app/screens/rooms/MyRooms.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #294      +/-   ##
===========================================
+ Coverage    33.45%   34.04%   +0.59%     
===========================================
  Files          235      235              
  Lines        13014    12991      -23     
  Branches      2765     2763       -2     
===========================================
+ Hits          4354     4423      +69     
+ Misses        8629     8532      -97     
- Partials        31       36       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thabisomatau thabisomatau merged commit 54fe507 into develop Oct 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Demo 4 frontend Frontend-related work medium priority Important but not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants