Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeakPickingProcessor skips peaks while combining them #255

Closed
superbock opened this issue Feb 25, 2017 · 0 comments
Closed

PeakPickingProcessor skips peaks while combining them #255

superbock opened this issue Feb 25, 2017 · 0 comments
Labels
Milestone

Comments

@superbock
Copy link
Collaborator

superbock commented Feb 25, 2017

E.g., if frames 2, 4, 6 are detections and combination width is set to be 3 (i.e. do not two consecutive onsets closer than 3 frames), the detection at frame 6 will be skipped because it is within 2 frames to the predecessor -- but it should not, since the predecessor was removed. We need to loop over all detections to handle this correctly.

@superbock superbock added the bug label Feb 25, 2017
@superbock superbock added this to the v0.15 milestone Feb 25, 2017
superbock pushed a commit that referenced this issue Feb 26, 2017
superbock pushed a commit that referenced this issue Feb 26, 2017
superbock pushed a commit that referenced this issue Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant