-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
online TempoEstimationProcessor #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbock
force-pushed
the
refactor_tempo
branch
5 times, most recently
from
June 20, 2017 11:48
cc8fe4a
to
005450d
Compare
superbock
force-pushed
the
refactor_tempo
branch
5 times, most recently
from
July 24, 2017 20:17
48d0cf8
to
886937c
Compare
superbock
force-pushed
the
refactor_tempo
branch
7 times, most recently
from
August 18, 2017 18:18
37e83bb
to
cbdbe8c
Compare
superbock
force-pushed
the
refactor_tempo
branch
9 times, most recently
from
September 3, 2017 10:33
8777d30
to
ceb5c74
Compare
superbock
changed the title
[WIP] refactor TempoEstimationProcessor
online TempoEstimationProcessor
Sep 3, 2017
superbock
force-pushed
the
refactor_tempo
branch
5 times, most recently
from
September 19, 2017 13:19
dcdbb8b
to
1c640e5
Compare
…ted histogram processor
…and add numpy-compatible slicing access
This variant is slower than the previous one but is more flexible.
superbock
force-pushed
the
refactor_tempo
branch
from
October 16, 2017 08:14
1c640e5
to
be97b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
TempoEstimationProcessor
online capable.TempoEstimationProcessor.interval_histogram
is refactored to use a dedicated histogram processor which is used to build the beat interval histogram. DifferentTempoHistogramProcessor
classes provide the needed functionality for both online and offline mode, namely CombFilter, ACF and DBN. With the work done in #286 this change was unavoidable, otherwiseTempoEstimationProcessor
would have had too many options and parameters.TODOs before this PR can be merged:
single --online
mode) or frame by frame (i.e.online
mode).interval_histogram
andinterval_histogram_online
methods or refactor the histogram stuff into dedicated classes (with the usualprocess_offline
andprocess_online
methods).