Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the option to normalize the observations of the ObservationModels #95

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Remove the option to normalize the observations of the ObservationModels #95

merged 1 commit into from
Feb 22, 2016

Conversation

superbock
Copy link
Collaborator

Needs to be confirmed that it's not needed for the PatternTrackingProcessor any more.

@fdlm
Copy link
Contributor

fdlm commented Feb 19, 2016

Just took a quick look at the diff. I also think the norm_observations parameter should be removed from the GMMPatternTrackingObservationModel. Normalising the inputs to an HMM is part of preprocessing the data, rather than the HMM (and the observation model is part thereof) itself. The PatternTrackingProcessor should do that itself if it is necessary.

superbock pushed a commit that referenced this pull request Feb 22, 2016
Merge pull request #95 from CPJKU/feature/remove_norm_observations
bf83050 
Remove the option to normalize the observations of the ObservationModels.
@superbock superbock merged commit bf83050 into develop Feb 22, 2016
@superbock superbock deleted the feature/remove_norm_observations branch February 22, 2016 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superbock @fdlm