Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introspection endpoint uncaught exception on get_token_info #502

Closed
ermakoves opened this issue Mar 1, 2018 · 1 comment
Closed

Introspection endpoint uncaught exception on get_token_info #502

ermakoves opened this issue Mar 1, 2018 · 1 comment
Assignees
@tpazderka
Labels
bug
Milestone
0.14.0

Comments

@ermakoves
Copy link
Contributor

ermakoves commented Mar 1, 2018 •
edited by tpazderka
Loading

https://github.com/OpenIDC/pyoidc/blob/3f21791df99aad8764b3ce796ba5689241ca86c4/src/oic/extension/provider.py#L804

On unpack token can got jwkest.jws.NoSuitableSigningKeys

File "/home/test_acc/.virtualenvs/p36/lib/python3.6/site-packages/oic/extension/token.py", line 181, in get_info return self.unpack(token)
File "/home/test_acc/.virtualenvs/p36/lib/python3.6/site-packages/oic/utils/jwt.py", line 116, in unpack info = self._verify(_rj, token)
File "/home/test_acc/.virtualenvs/p36/lib/python3.6/site-packages/oic/utils/jwt.py", line 99, in _verify return rj.verify_compact(token, keys) 
File "/home/test_acc/.virtualenvs/p36/lib/python3.6/site-packages/jwkest/jws.py", line 517, in verify_compact return self.verify_compact_verbose(jws, keys, allow_none, sigalg)['msg']
File "/home/test_acc/.virtualenvs/p36/lib/python3.6/site-packages/jwkest/jws.py", line 568, in verify_compact_verbose "No key with kid: %s" % (self.jwt.headers["kid"])) jwkest.jws.NoSuitableSigningKeys: No key with kid:
@tpazderka tpazderka added the bug label Mar 5, 2018
@tpazderka
Copy link
Collaborator

The IntrospectionEndpoint should expect this and return some reasonable error message.

@tpazderka tpazderka added this to the 0.14.0 milestone Mar 9, 2018
@tpazderka tpazderka self-assigned this Apr 18, 2018
tpazderka added a commit that referenced this issue Apr 18, 2018
@tpazderka
Fix responses from IntrospectionEndpoint
cfe1a69 
IntrospectionEndpoint should return regular response with active=False
if it cannot verify the activity of the token for any reason.

Close #502
@tpazderka tpazderka mentioned this issue Apr 18, 2018
Merged
2 tasks
tpazderka added a commit that referenced this issue Apr 19, 2018
@tpazderka
Fix responses from IntrospectionEndpoint
92629b1 
IntrospectionEndpoint should return regular response with active=False
if it cannot verify the activity of the token for any reason.

Close #502
tpazderka added a commit that referenced this issue Apr 19, 2018
@tpazderka
Fix responses from IntrospectionEndpoint
8b3106b 
IntrospectionEndpoint should return regular response with active=False
if it cannot verify the activity of the token for any reason.

Close #502
tpazderka added a commit that referenced this issue Apr 19, 2018
@tpazderka
Fix responses from IntrospectionEndpoint (#523)
21218b4 
IntrospectionEndpoint should return regular response with active=False
if it cannot verify the activity of the token for any reason.

Close #502
andrewkrug pushed a commit to mozilla-iam/pyoidc that referenced this issue Jun 6, 2019
@tpazderka @andrewkrug
Fix responses from IntrospectionEndpoint (CZ-NIC#523)
e1bad99 
IntrospectionEndpoint should return regular response with active=False
if it cannot verify the activity of the token for any reason.

Close CZ-NIC#502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpazderka tpazderka

Labels
bug
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
2 participants
@tpazderka @ermakoves