Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wants the original non-parsed JWT and not an IDToken instance. #708

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

rohe
Copy link
Collaborator

@rohe rohe commented Nov 1, 2019

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #708 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   63.84%   63.83%   -0.01%     
==========================================
  Files          63       63              
  Lines       11688    11683       -5     
  Branches     2053     2053              
==========================================
- Hits         7462     7458       -4     
+ Misses       3658     3656       -2     
- Partials      568      569       +1
Impacted Files Coverage Δ
src/oic/oic/message.py 69.89% <ø> (+0.27%) ⬆️
src/oic/oauth2/message.py 73.64% <ø> (-0.04%) ⬇️
src/oic/oauth2/grant.py 84.84% <100%> (-1.42%) ⬇️
src/oic/oic/__init__.py 66.37% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfd8d1...f12a2b7. Read the comment docs.

@CZ-NIC CZ-NIC deleted a comment Nov 2, 2019
@rohe
Copy link
Collaborator Author

rohe commented Nov 2, 2019

I think mypy is wrong !

@tpazderka
Copy link
Collaborator

Yes, it cannot recognize the dynamically created attributes of the Client. You can probably add the ignore statement on the offending line (type: ignore).

I will go through the rest of the PR later today.

CHANGELOG.md Outdated Show resolved Hide resolved
tests/test_oic.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants