Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OpenID Client registration with JWT #719

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

JustKiddingCode
Copy link
Contributor

When register an OpenID Client,
registration tokens that are valid JWTs are now passed through to the
OpenID Provider. Every other string is still base64 encoded.
This closes #718

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
    Don't know if the previous two are applicable.
  • New code is annotated.
  • Changes are covered by tests.

registration tokens that are valid JWTs are now passed through to the
OpenID Provider. Every other string is still base64 encoded.
@JustKiddingCode JustKiddingCode changed the title When register an OpenID Client, Allow OpenID Client registration with JWT Nov 21, 2019
Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add entry in CHANGELOG.

Also the quality checks are failing. Please run make isort and make blacken on the code. That should fix most of the issues.

@tpazderka
Copy link
Collaborator

Thank you for the contribution!

@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #719 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   63.77%   63.79%   +0.02%     
==========================================
  Files          63       63              
  Lines       11689    11696       +7     
  Branches     2056     2056              
==========================================
+ Hits         7455     7462       +7     
  Misses       3662     3662              
  Partials      572      572
Impacted Files Coverage Δ
src/oic/oic/__init__.py 66.6% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290126f...bea86f7. Read the comment docs.

@tpazderka tpazderka merged commit 01b27c4 into CZ-NIC:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Registration with Inital Access Token does not work with Keycloak
3 participants