Settings

[tpazderka]

• Any changes relevant to users are recorded in the CHANGELOG.md.
• The documentation has been updated, if necessary.
• New code is annotated.
• Changes are covered by tests.

---

Basic idea of settings. Mostly as a proof of concept and for design review.

This attempts to fix several issues regarding documentation (autodoc), too complex init methods and inconsistent settings..

The classes are not complete (they miss any sort of loading from files).

Also the conversion is not finished.

[schlenk]

his => this

[schlenk]

The general idea is sound. We have way to many constructor options all over the place.

[tpazderka]

Thanks for the feedback. Will work on this a little bit more to propagate the settings to all necessary classes. We can then expand their content.

[tpazderka]

Thanks, will work on this more during the week to get the basic structure.

[codecov-io]

Codecov Report

Merging #723 into master will decrease coverage by 0.19%.
The diff coverage is 46.2%.

@@            Coverage Diff            @@
##           master     #723     +/-   ##
=========================================
- Coverage   63.88%   63.69%   -0.2%     
=========================================
  Files          64       64             
  Lines       11692    11826    +134     
  Branches     2062     2091     +29     
=========================================
+ Hits         7470     7533     +63     
- Misses       3652     3697     +45     
- Partials      570      596     +26

Impacted Files	Coverage Δ
src/oic/oic/__init__.py	65.61% <25%> (-0.79%)	⬇️
src/oic/oauth2/__init__.py	69.45% <30.76%> (-1.72%)	⬇️
src/oic/oauth2/consumer.py	77.97% <30.76%> (-4.08%)	⬇️
src/oic/oauth2/base.py	56.33% <33.33%> (-6.38%)	⬇️
src/oic/oic/provider.py	74.19% <45.45%> (-0.27%)	⬇️
src/oic/oauth2/provider.py	70.78% <46.15%> (-0.43%)	⬇️
src/oic/extension/client.py	39.04% <50%> (+0.46%)	⬆️
src/oic/oic/claims_provider.py	79.31% <53.84%> (-3.55%)	⬇️
src/oic/utils/settings.py	86.2% <85.71%> (+86.2%)	⬆️
src/oic/utils/http_util.py	69.82% <0%> (+0.57%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d28a6a...00a6af9. Read the comment docs.

[tpazderka]

I think that the basic design of code is done. I will investigate the failure of integration tests, but the code/documentation is probably ready for review.

I am not sure about the type checking in __setitem__. If we drop 3.5, we could use pydantic for the same effect. But 3.5 still has support... :(

I would like to add some loading methods and other settings in separate issues.

[tpazderka]

OK, test are fixed. I am going to ignore codacy errors as they are mostly false positives.

[tpazderka]

Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Complexity increasing per file
==============================
- src/oic/oic/claims_provider.py  1
- src/oic/oauth2/consumer.py  1
- src/oic/utils/settings.py  5
         

Clones added
============
- src/oic/oauth2/base.py  2
- src/oic/oauth2/__init__.py  5
- src/oic/oic/__init__.py  4
- src/oic/oic/provider.py  2
- src/oic/oauth2/provider.py  2
         

See the complete overview on Codacy

[schlenk]

Looks good.