Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RP-Initiated Logout To Accept id_token_hint #829

Merged

Conversation

infohash
Copy link
Contributor

@infohash infohash commented Nov 3, 2022

Addresses #826

According to OIDC specs on RP-Initiated logout, the expected arguments are post_logout_redirect_uri and id_token_hint that accepts raw ID token JWT.

Added a default parameter id_token_hint in oic.Client.construct_EndSessionRequest & oic.Client.do_end_session_request to make them comply with OIDC specs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #829 (da668f5) into master (2735921) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head da668f5 differs from pull request most recent head ef8afa2. Consider uploading reports for the commit ef8afa2 to get more accurate results

@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
- Coverage   63.80%   63.77%   -0.04%     
==========================================
  Files          64       64              
  Lines       11877    11877              
  Branches     2158     2158              
==========================================
- Hits         7578     7574       -4     
- Misses       3695     3699       +4     
  Partials      604      604              
Impacted Files Coverage Δ
src/oic/oic/__init__.py 64.99% <100.00%> (ø)
src/oic/utils/authn/user.py 63.41% <0.00%> (-0.82%) ⬇️
src/oic/utils/http_util.py 69.25% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@infohash
Copy link
Contributor Author

@tpazderka @schlenk Can you review and prepare the release for 3.11?

Suppress warnings about implicit optional.
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schlenk schlenk merged commit f4a483d into CZ-NIC:master Nov 11, 2022
@infohash infohash deleted the bugfix/end-session-logout-missing-id-token-hint branch November 11, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants