Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature table to b3dm #200

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Add feature table to b3dm #200

merged 1 commit into from
Mar 28, 2017

Conversation

lilleyse
Copy link
Contributor

This adds feature table support to b3dm tiles. With future enhancements like explicit tiling schemes, per-feature bounding volumes, and others down the road, it will be important for b3dm to have a feature table to store per-feature information that cannot be contained within the glTF model. This means batchIds are still part of the glTF, but per-feature bounding volumes (for example) would be part of the feature table.

New layout:

layout

The batchLength item in the header is removed and now moved to a BATCH_LENGTH property of the feature table. This is similar to INSTANCES_LENGTH for i3dm and POINTS_LENGTH/BATCH_LENGTH for pnts.

There was some discussion in the past regarding glTF byte alignment, since 28 is not on an even 8-byte split. The normal recommendation would still apply here, just pad the feature table or, if it exists, the batch table.

In the Cesium implementation we will continue to detect legacy headers, so old tilesets will still work for the time being.

@pierotofy
Copy link
Contributor

Looks good to me!

@lilleyse
Copy link
Contributor Author

Cesium implementation: CesiumGS/cesium#5165 ... and more to come if the changes here look good.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 28, 2017

@pmconne heads up for this small change to the b3dm header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants