Expose CZML helper functions. #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we're skipping the tests for now since these are temporary? |
|
Yes and no. They are currently called many many times in our CZML processing tests; they are just not called explicitly. If we were planning to keep them around forever, then I would probably add explicit tests, but I'm fairly certain they will be gone in a month or two. |
|
Tests pass, and access to these functions is vital for custom CZML. Merging. |
emackey
added a commit
that referenced
this pull request
Sep 3, 2013
…ketData Expose CZML helper functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1080 accidentally removed some helper functions needed for custom CZML processing. I expect these function to go away in the near future, but they are definitely needed for now in apps that use custom CZML.
CC @emackey