Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of 3D Tiles reference doc #3458

Merged
merged 19 commits into from
Jan 26, 2016
Merged

Start of 3D Tiles reference doc #3458

merged 19 commits into from
Jan 26, 2016

Conversation

pjcozzi
Copy link
Contributor

@pjcozzi pjcozzi commented Jan 25, 2016

Part of #3241.

More reference doc to come, but it will be in a separate PR also with some renames.

* Do not construct this directly. Access it through {@link Cesium3DTile#content}.
* </p>
*
* @alias Batched3DModel3DTileContentProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Empty3DTileContentProvider

* @param {CullingVolume} cullingVolume The culling volume whose intersection with the tile is to be tested.
* @returns {Number} A plane mask as described above in {@link CullingVolume#computeVisibilityWithPlaneMask}.
*
* @private
*/
Cesium3DTile.prototype.canRequestContent = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation should be above Cesium3DTile.prototype.visiblity right?

@lilleyse
Copy link
Contributor

That's all my comments, I probably missed some things but we can do a more thorough check when the doc is complete.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 26, 2016

Thanks, updated.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 26, 2016

@lilleyse merged in 3d-tiles.

@lilleyse
Copy link
Contributor

Nice merging in now.

lilleyse added a commit that referenced this pull request Jan 26, 2016
@lilleyse lilleyse merged commit eab81fb into 3d-tiles Jan 26, 2016
@lilleyse lilleyse deleted the 3d-tiles-doc branch January 26, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants