Use cube map for point light shadows #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
force-pushed
the
shadows-point-light2
branch
from
f5bd601
to
e2f05f6
Compare
| @@ -308,6 +308,11 @@ define([ | |||
| gl.bindFramebuffer(gl.FRAMEBUFFER, null); | |||
| }; | |||
|
|
|||
| Framebuffer.prototype._attachTexture = function(context, attachment, texture) { | |||
| context.bindFramebuffer(this); | |||
There was a problem hiding this comment.
It would be cleaner just to call _bind here, but then you end up re-binding the FBO when you render the shadow casters.
pjcozzi
added a commit
that referenced
this pull request
Mar 17, 2016
Use cube map for point light shadows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2594 and merging into #3711
I experimented with using a cube map instead a 2d texture. Sometimes I see a 5-10 fps increase, and sometimes it's equal. The organization is roughly the same.
The point light shadows work in both cases, so either we can keep both code paths in or chose one.