Shadows derived commands #3828
Merged
Shadows derived commands #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are the flags castShadows and receiveShadows on each command.
|
@lilleyse this is all you. |
| @@ -1376,6 +1387,9 @@ define([ | |||
|
|
|||
| if (scene.debugShowCommands || scene.debugShowFrustums) { | |||
| executeDebugCommand(command, scene, passState); | |||
| } else if (command.receiveShadows && defined(command.derivedCommands.shadows.receiveCommand)) { | |||
| // TODO | |||
There was a problem hiding this comment.
Is this TODO still needed?
|
I like how the new code is organized, it's definitely an improvement. The one main fix is the terrain normals, but otherwise this all looks good. |
|
@lilleyse This is ready for another look. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges
masterwith theshadowsbranch and updates shadows to use derived commands.