Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple shadow maps #3852

Merged
merged 17 commits into from
Apr 15, 2016
Merged

Multiple shadow maps #3852

merged 17 commits into from
Apr 15, 2016

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Apr 14, 2016

  • Add ability to cast into multipl shadow maps; however, only receive shadows from scene.shadowMap.
  • Updates the globe for each shadow map camera.

lilleyse and others added 17 commits April 8, 2016 10:08
@lilleyse
getTerrainShadowCommands temp
cc09976
@bagnell
Merge branch 'shadows-commands' into shadows-multiple
6babfbd 
Conflicts:
	Source/Scene/Scene.js
@bagnell
Merge branch 'shadows-derived' into shadows-merged
916050d
@bagnell
Merge branch 'shadows-commands' into shadows-merged
249322a
@bagnell
Temporarily disable globe update when getting terrain commands.
21f79df
@bagnell
Move around shadow map and globe updates. Make an array of shadow maps.
8648679
@bagnell
Add ability to render to multiple shadow maps.
aba1981
@bagnell
Add Sandcastle example to for multiple shadow maps and demonstrates t…
bd98b6b 
…hat cast to multiple shadow maps works.
@bagnell
Merge branch 'shadows' into shadows-multiple
b3c5fcf
@bagnell
Merge branch 'shadows-commands' into shadows-multiple
f1ede3c
@bagnell
Revert changes to shadows Sandcastle example.
5677298
@bagnell
Updates after merge.
e59ef50
@bagnell
Merge branch 'shadows-commands' into shadows-multiple
ad94eb8
@bagnell
Update after merge.
1b89577
@lilleyse
Formatting
524e431
@lilleyse
Remove FrameState.shadowMap
6198cfb
@lilleyse
Remove TODO
9c6f37f
@lilleyse
Copy link
Contributor

The code changes all look good to me. I'm noticing some tiles flickering in and out in Shadows.html. It may be related to the lack of a proper sseFactor for orthographic cameras, or maybe something else.

@lilleyse
Copy link
Contributor

Merging this just to combine all the shadow branches together. There will be a separate PR for fixing Globe.update.

@lilleyse lilleyse merged commit 1abfe29 into shadows-commands Apr 15, 2016
@lilleyse lilleyse deleted the shadows-multiple branch April 15, 2016 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagnell @lilleyse