Cesium3DTile check for ready promise after request is made #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge in |
Ready |
|
This is OK with me. @mramato did you plan to look at this? |
| } | ||
| return false; |
There was a problem hiding this comment.
Since we prefer early return, flip the above if(defined(promise)) check and return false immediately to make the code cleaner.
There was a problem hiding this comment.
Same comment in the other 3 places in this PR where this is happening.
|
Just that one comment. Thanks @lilleyse |
|
Updated. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3453
A tile now starts waiting for its readyPromise only when it is requested rather than at construction time. Empty tiles are a special case where the readyPromise is checked right away because it is resolved immediately.