Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix billboard and label clamping #4493

Merged
merged 3 commits into from
Oct 24, 2016
Merged

Fix billboard and label clamping #4493

merged 3 commits into from
Oct 24, 2016

Commits on Oct 21, 2016

  1. Fix billboard and label clamping 

    Turns out that billboard and label clamping were fundamentally broken
because the `QuadtreePrimitive` was processing the tile queue in the wrong
order.  It was always pulling new tiles from the back of the array rather
than the front, which meant that data would get processed in the wrong
order causing old tiles to take precedence over newer tiles.

Addtiionally, there was a bad if block in `Label.js` which caused the
initial position of the individual label billboards to not be properly set
when clamping was on, instead we should always set the positions before
calling `_updateClamping` (if needed).

Fixes #4396 and #4062
    @mramato
    mramato committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    3af7d9b View commit details
    Browse the repository at this point in the history

  2. Update CHANGES

    @mramato
    mramato committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    8f357c3 View commit details
    Browse the repository at this point in the history

  3. Tweak CHANGES.md

    @pjcozzi
    pjcozzi authored Oct 21, 2016
    Configuration menu
    Copy the full SHA
    563fd11 View commit details
    Browse the repository at this point in the history