Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use depth-stencil for FXAA #4747

Merged
merged 3 commits into from
Dec 13, 2016
Merged

Use depth-stencil for FXAA #4747

merged 3 commits into from
Dec 13, 2016

Conversation

lilleyse
Copy link
Contributor

I finally discovered why stencil operations (ground primitives and silhouettes) were not working on my machine. Normally the globe depth fbo is the principal fbo for the scene, but when the depth texture extension is not supported the FXAA fbo is used. I needed to change the FXAA depth texture/renderbuffer to use depth-stencil instead.

This also explains how we got away with not passing in stencil : true to the WebGL context. Even if the default FBO is not initialized that way you can still create FBOs with stencil buffers. So when I turned off depth textures and fxaa, so as to use the default FBO, the ground primitives were in fact broken. I just copied some of the code from #4314 into here to deal with that.

@pjcozzi pjcozzi mentioned this pull request Dec 13, 2016
6 tasks
@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 13, 2016

Excellent catch, thanks @lilleyse!

@pjcozzi pjcozzi merged commit 56aebfc into master Dec 13, 2016
@pjcozzi pjcozzi deleted the depth-stencil branch December 13, 2016 17:12
@lilleyse lilleyse mentioned this pull request Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants