Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GeometryPipeline.computeBinormalAndTangent for 1.31 #5053

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

shehzan10
Copy link
Member

Fixes #4859

@hpinkos
Copy link
Contributor

hpinkos commented Mar 1, 2017

@shehzan10 merge master

@shehzan10
Copy link
Member Author

I had pull the latest master, but I think one of the PRs got merged between fetching and pushing.

Updated now.

@lilleyse
Copy link
Contributor

lilleyse commented Mar 1, 2017

Looks good.

@lilleyse lilleyse merged commit 16c8a10 into CesiumGS:master Mar 1, 2017
@lilleyse
Copy link
Contributor

lilleyse commented Mar 1, 2017

Ah forgot to remove the deprecationWarning include, I'll update master directly.

@shehzan10
Copy link
Member Author

shehzan10 commented Mar 1, 2017

Oh I missed that too. Didn't show up in JSHint either (I don't think the AMD modules do anyway).

Ah forgot to remove the deprecationWarning include, I'll update master directly.

Thanks

@lilleyse
Copy link
Contributor

lilleyse commented Mar 1, 2017

Fixed in 03d0f6a

@hpinkos
Copy link
Contributor

hpinkos commented Mar 1, 2017

Didn't show up in JSHint either

We don't have jsHint configured to detect unused parameters in this repo. There are tons of defines that aren't actually used. Someone usually goes through and cleans that up maybe once or twice a year.

@hpinkos hpinkos mentioned this pull request Mar 1, 2017
@shehzan10 shehzan10 deleted the remove-binormal branch March 1, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants