Fix Mapbox default token warning showing up all the time #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalmykov
changed the title
|
Good catch @kalmykov, thanks! |
|
Added a note to CHANGES in 3115443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error made in #4749 :
MapboxImageryProviderchecks for parameteroptions.keyinstead ofoptions.accessToken(this is probably just copy-paste fromBingImageryProvider) for detecting usage of default access token. This results in permanent access token warning, no matter which token you use.Temporary workaround for this is to pass 2 parameters, both
accessTokenandkey, with same value.I've sent CLA back in January 2016. I can re-send it if you need.