Geocoder lon lat bug #5407
Merged
Geocoder lon lat bug #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great @WilliamKHo, thanks! Can you just add a comment to |
|
@WilliamKHo - just a reminder to update |
added 2 commits
June 5, 2017 16:39
|
Hi please review. Sorry about that delay my email filter was not doing what it was supposed to. |
|
Great @WilliamKHo, thanks! Please make a comment on the forum post linked in #4713 that this has been fixed and will be included in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4713. Extended our
CartographicGeocoderServiceto evaluate queries for NSEW coordinates (i.e. "39N 75W" or "20.5E 60N"). This fixes the problem of replacing cartographic queries with incorrectly formatted coordinates in the geocoder. To review: code addition and new tests.