Classification primitive #5625
Classification primitive #5625
Conversation
…ground primitive.
|
Does this work OK with translucent objects? |
| <meta http-equiv="X-UA-Compatible" content="IE=Edge,chrome=1"> <!-- Use Chrome Frame in IE --> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no"> | ||
| <meta name="description" content="Draw the intersection of a volume and a photgrammetry dataset."> | ||
| <meta name="cesium-sandcastle-labels" content="Development"> |
There was a problem hiding this comment.
Are you sure this should go under Development? I would rather it be more prominent.
| camera.viewBoundingSphere(boundingSphere, new Cesium.HeadingPitchRange(0.0, -0.5, boundingSphere.radius)); | ||
| camera.lookAtTransform(Cesium.Matrix4.IDENTITY); | ||
|
|
||
| var dimensions = new Cesium.Cartesian3(40.0, 30.0, 50.0); |
There was a problem hiding this comment.
Can we use a slightly different geometry that shows how this is different than a GroundPrimitive? For example, something where the bottom cap is above the ground and/or even something on the underside of a tree, polyline on the roof, etc. It would be fine to have a few short examples here.
| this.debugShowShadowVolume = defaultValue(options.debugShowShadowVolume, false); | ||
| this._debugShowShadowVolume = false; | ||
|
|
||
| this._extruded = defaultValue(options._extruded, false); |
There was a problem hiding this comment.
Perhaps add a comment that this is used by the GroundPrimitive. At first glance, I thought this was just a leftover from copy-paste.
| * @param {Boolean} [options.debugShowShadowVolume=false] For debugging only. Determines if the shadow volume for each geometry in the primitive is drawn. Must be <code>true</code> on | ||
| * creation for the volumes to be created before the geometry is released or options.releaseGeometryInstance must be <code>false</code>. | ||
| * | ||
| * @see Primitive |
There was a problem hiding this comment.
Do you also want Primitive and GroundPrimitive to reference this with @see?
| * @constructor | ||
| * | ||
| * @param {Object} [options] Object with the following properties: | ||
| * @param {Array|GeometryInstance} [options.geometryInstances] The geometry instances to render. |
There was a problem hiding this comment.
This should be of length 1, right? Mention it.
Leave it plural so we could easily relax the requirement later.
| * be <code>undefined</code> if <code>options.releaseGeometryInstances</code> | ||
| * is <code>true</code> when the primitive is constructed. | ||
| * <p> | ||
| * Changing this property after the primitive is rendered has no effect. |
There was a problem hiding this comment.
Should this be readonly here and in GroundPrimitive/Primitive?
Of course the primitive can be translucent, but does it highlight translucent geometry? No.Neither will |
|
Submitted #5659 |
|
|
|
@pjcozzi This is ready for another look. |
|
Looks great! Just a small tweak: can the Sandcastle example just create all the classification primitives up front, and then use the buttons (or a dropdown) to fly from one view to the other. Otherwise, the examples doesn't really show anything until you click one of the buttons. |
|
Actually, it's good enough to keep the example as is for now. |
ClassificationPrimitivewhich defines a volume and draws the intersection of the volume with terrain and 3D Tiles.GroundPrimitivewhich is a special type ofClassificationPrimitive.CESIUM_3D_TILESpass when picking.