Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real minus signs #6016

Merged
merged 3 commits into from
Nov 30, 2017
Merged

Real minus signs #6016

merged 3 commits into from
Nov 30, 2017

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Nov 30, 2017

Change en-dashes to minus signs in RegExps. See #6011 (comment).

Note there are two commits here. The first one is tests only, and is expected to fail. The second one is the fix, and is expected to pass.

@cesium-concierge
Copy link

Signed CLA is on file.

@emackey, thanks for the pull request! Maintainers, we have a signed CLA from @emackey, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@emackey emackey requested a review from mramato November 30, 2017 18:09
@emackey
Copy link
Contributor Author

emackey commented Nov 30, 2017

Well the second commit flaked out in Travis, but a third commit to CHANGES.md passed.

@mramato
Copy link
Contributor

mramato commented Nov 30, 2017

Thanks @emackey!

@mramato mramato merged commit fe85699 into master Nov 30, 2017
@mramato mramato deleted the real-minus-signs branch November 30, 2017 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants