Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smokescreen test for Node support to travis. #6177

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Add smokescreen test for Node support to travis. #6177

merged 2 commits into from
Feb 1, 2018

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Feb 1, 2018

This PR should fail, showing that Cesium is broken in Node (which it is). Once travis fails, I'll push a fix for Cesium in Node.

@cesium-concierge
Copy link

Signed CLA is on file.

@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

`buildModuleUrl` does not currently work in Node and shouldn't be called
during the intialization process.
@mramato
Copy link
Contributor Author

mramato commented Feb 1, 2018

The first build failed and I pushed a fix.

The real fix here is to make buildModuleUrl work in Node, but that is a little more involved and should be done as part of a separate PR. The important thing here is that we'll no longer accidentally ship a completely broken version of Cesium to Node users.

@mramato mramato requested a review from ggetz February 1, 2018 20:20
@mramato
Copy link
Contributor Author

mramato commented Feb 1, 2018

Not sure why this isn't showing up, but the build already passed: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/336272112

This is good to go. We'll probably want to unpublish 1.42 from NPM as well

@ggetz ggetz merged commit bf3bf64 into master Feb 1, 2018
@ggetz ggetz deleted the node branch February 1, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants